upgrade emsdk to v4.0.11 #25477
Merged
upgrade emsdk to v4.0.11 #25477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Emscripten SDK (emsdk) from version 4.0.8 to 4.0.11 to fix a build break on Windows+Ninja. The upgrade involves updating version references across multiple build configuration files and simplifying WebAssembly async wrapper code to align with newer emsdk capabilities.
Key changes:
- Updated emsdk version references from 4.0.8 to 4.0.11 across build scripts and configuration files
- Simplified WebAssembly async function wrapping by removing complex debug/release build handling logic
- Updated compiler flag syntax and added character conversion warning handling for compatibility
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/ci_build/github/azure-pipelines/templates/linux-wasm-ci.yml | Updated emsdk install/activate commands to use version 4.0.11 |
| tools/ci_build/build_args.py | Changed default emsdk_version argument from 4.0.8 to 4.0.11 |
| onnxruntime/wasm/pre-async.js | Simplified async wrapper implementation by removing debug/release build handling |
| cmake/onnxruntime_webassembly.cmake | Updated exception catching flag syntax and configuration |
| cmake/onnxruntime_unittests.cmake | Added character conversion warning suppression |
| cmake/external/emsdk | Updated submodule commit to emsdk 4.0.11 |
| cmake/CMakeLists.txt | Added character conversion compiler flag check |
| .gitmodules | Updated emsdk submodule branch from 4.0.8 to 4.0.11 |
snnn
approved these changes
Jul 22, 2025
sanketkaleoss
pushed a commit
to sanketkaleoss/onnxruntime
that referenced
this pull request
Aug 11, 2025
### Description ### Motivation and Context Fix the build break on Windows+Ninja
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Fix the build break on Windows+Ninja